test: more test coverage for maxConnections #1855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
test
| server.listen(common.PORT, function() { | ||
| createConnection(0) | ||
| .then(createConnection.bind(null, 1)) | ||
| .then(function() {connections[0].end();}) |
There was a problem hiding this comment.
style: space between { }
|
Updated the branch to conform to the style comments from @brendanashworth. |
|
|
||
| var server = net.createServer(function(socket) { | ||
| socket.on('data', function(data) { | ||
| console.error('received message: ' + data.toString()); |
There was a problem hiding this comment.
the data.toString is unnecessary here
|
Thanks for adding this test, it was really bad that something like this was untested beforehand. |
|
Updated commit based on all comments from @brendanashworth |
| .then(closeConnection.bind(null, 2)); | ||
| }); | ||
|
|
||
| process.on('exit', function () { |
There was a problem hiding this comment.
style: no space after function, so function() {
|
Sorry I missed the little style nitpick. Other than that, this LGTM. edit: good use of promises btw 😄 |
If the server is not accepting connections because maxConnections is exceeded, the server should start accepting connections again when a connection closes.
|
OK, nit picked, new commit pushed! |
brendanashworth
pushed a commit
that referenced
this pull request
Jun 3, 2015
If the server is not accepting connections because maxConnections is exceeded, the server should start accepting connections again when a connection closes. PR-URL: #1855 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
|
Thanks, landed in bd99e8d. |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
If the server is not accepting connections because maxConnections is exceeded, the server should start accepting connections again when a connection closes. PR-URL: nodejs/node#1855 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server is not accepting connections because maxConnections
is exceeded, the server should start accepting connections again
when a connection closes.
Eliminates a
TODOcomment. ref: #264