tools,makefile: fix file open mode and cleanup tap file

[thefourtheye]

1st commit:

By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

2nd commit:

Make make clean cleanup the generated tap file as well.

Fixes: #2834

cc @nodejs/build

[jbergstroem]

LGTM

[bnoordhuis]

LGTM

[bnoordhuis]

...with a teeny nit about the commit logs: s/Open/open/ and s/Makefile/build/ for consistency.

[rvagg]

lgtm, thanks for doing this @thefourtheye

[orangemocha]

I wonder: does appending to a .tap file ever make sense? If not, it would be better to have the test runner delete the file (instead of make test-ci).

[thefourtheye]

@orangemocha If test-runner deletes the file, then we will not get to see the TAP results, right?

[evanlucas]

Maybe delete before running the tests?

[thefourtheye]

@evanlucas This patch does something similar. Opens the file in write mode, which truncates the file if it exists.

[orangemocha]

@thefourtheye : sorry, I didn't catch that before. Your first commit already does what I was suggesting :)

LGTM

[thefourtheye]

Thanks for the review people :-) Landed in 467eff2 and 91e7e9c

[rvagg]

@thefourtheye I'm just noticing that these two commits made it in with PR-URL: #2837 and Fixes: #2834, this is probably a simple oversight but please be sure to include full URLs in future to make accounting easier

[thefourtheye]

@rvagg Ah, sorry about that. I just used that GitHub format. I'll keep it in mind for the next time.

[jbergstroem]

@thefourtheye downside being very hard to click in terminal :)