test: skip inferredName on 12

V8 changed the function name inference algorithm, which affected one of our test cases. Even if it's reverted/fixed upstream, it won't make it's way into v12, so skip that particular test for this version. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=9807 PR-URL: #330 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs · Jan 21, 2020 · 2cc07cd · 2cc07cd
1 parent 1faa880
commit 2cc07cd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/test/common.js b/test/common.js
@@ -332,3 +332,10 @@ Session.prototype.hasSymbol = function hasSymbol(symbol, callback) {
     }
   });
 };
+
+function nodejsVersion() {
+  const version = process.version.substring(1, process.version.indexOf('-'));
+  const versionArray = version.split('.').map(s => Number(s));
+  return versionArray;
+}
+exports.nodejsVersion = nodejsVersion;
diff --git a/test/plugin/frame-test.js b/test/plugin/frame-test.js
@@ -5,6 +5,7 @@ const { promisify } = require('util');
 const tape = require('tape');
 
 const common = require('../common');
+const { nodejsVersion } = common;
 
 const sourceCodes = {
   "fnFunctionName": [
@@ -86,7 +87,8 @@ tape('v8 stack', async (t) => {
     t.ok(/<exit>/.test(exit), 'exit frame');
     t.ok(/crasher/.test(crasher), 'crasher frame');
     t.ok(/<adaptor>/.test(adapter), 'arguments adapter frame');
-    t.ok(/\sfnInferredName\(/.test(fnInferredName), 'fnInferredName frame');
+    if (nodejsVersion()[0] < 12)
+      t.ok(/\sfnInferredName\(/.test(fnInferredName), 'fnInferredName frame');
     t.ok(/\sModule.fnInferredNamePrototype\(/.test(fnInferredNamePrototype),
          'fnInferredNamePrototype frame');
     t.ok(/\sfnFunctionName\(/.test(fnFunctionName), 'fnFunctionName frame');
@@ -111,14 +113,16 @@ tape('v8 stack', async (t) => {
       fatalError(t, sess, "Couldn't determine fnFunctionName's frame number");
     }
 
-    const fnInferredNamePrototypeFrame =
-      fnInferredNamePrototype.match(/frame #([0-9]+)/)[1];
-    if (fnInferredNamePrototypeFrame) {
-      await testFrameList(t, sess, fnInferredNamePrototypeFrame,
-                          sourceCodes['fnInferredNamePrototype']);
-    } else {
-      fatalError(t, sess,
-                 "Couldn't determine fnInferredNamePrototype's frame number");
+    if (nodejsVersion()[0] < 12) {
+      const fnInferredNamePrototypeFrame =
+        fnInferredNamePrototype.match(/frame #([0-9]+)/)[1];
+      if (fnInferredNamePrototypeFrame) {
+        await testFrameList(t, sess, fnInferredNamePrototypeFrame,
+                            sourceCodes['fnInferredNamePrototype']);
+      } else {
+        fatalError(t, sess,
+                  "Couldn't determine fnInferredNamePrototype's frame number");
+      }
     }
 
     const fnInferredNameFrame = fnInferredName.match(/frame #([0-9]+)/)[1];