Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Loaders Team Meeting 2023-05-09 #140

Closed
mhdawson opened this issue May 5, 2023 · 2 comments
Closed

Node.js Loaders Team Meeting 2023-05-09 #140

mhdawson opened this issue May 5, 2023 · 2 comments
Assignees

Comments

@mhdawson
Copy link
Member

mhdawson commented May 5, 2023

Time

UTC Tue 09-May-2023 18:00 (06:00 PM):

Timezone Date/Time
US / Pacific Tue 09-May-2023 11:00 (11:00 AM)
US / Mountain Tue 09-May-2023 12:00 (12:00 PM)
US / Central Tue 09-May-2023 13:00 (01:00 PM)
US / Eastern Tue 09-May-2023 14:00 (02:00 PM)
EU / Western Tue 09-May-2023 19:00 (07:00 PM)
EU / Central Tue 09-May-2023 20:00 (08:00 PM)
EU / Eastern Tue 09-May-2023 21:00 (09:00 PM)
Moscow Tue 09-May-2023 21:00 (09:00 PM)
Chennai Tue 09-May-2023 23:30 (11:30 PM)
Hangzhou Wed 10-May-2023 02:00 (02:00 AM)
Tokyo Wed 10-May-2023 03:00 (03:00 AM)
Sydney Wed 10-May-2023 04:00 (04:00 AM)

Or in your local time:

Links

Agenda

Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

  • console.log failure while working with worker threads. #30491

Invited

  • Loaders team: @nodejs/loaders

Observers/Guests

Notes

The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this May 5, 2023
@GeoffreyBooth
Copy link
Member

A Slack conversation turned into an impromptu (text-based) meeting: https://openjs-foundation.slack.com/archives/C053UCCP940/p1683406821698669?thread_ts=1683400385.659389&cid=C053UCCP940

I can add the whole thread as a “meeting” to our meeting notes, but I wanted to save the conclusion here where it could be more easily found:

Next steps, in priority order

  1. Add support for the load hook to understand source returned when type is commonjs.
  2. Add the registerLoader API.
  3. Currently we spawn a new loaders thread for each new application Worker thread. Change this so that there’s always only one loaders thread, no matter how many application (main + worker) threads there are.
  4. Split out the port aspect of globalPreload into its own API, with consideration given to communication between the one loaders thread and the potentially many application threads.
  5. Remove the globalPreload hook, as it should no longer be needed now that registerLoader and the new communications API have landed.
  6. If desired, add support to new Worker for spawning a new loaders thread alongside the new worker thread. Allow either inheriting the loaders defined at initial process launch or defining new ones specific to that new loaders thread.

Finishing all of these (or all but the last, optional, one) will complete the items in https://github.com/nodejs/loaders#milestone-2-stability which are our remaining to-do items before hopefully marking the Loaders API as stable.

@JakobJingleheimer
Copy link
Contributor

Our active items are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants