-
Notifications
You must be signed in to change notification settings - Fork 501
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nan tests hit DCHECKs on latest node #858
Comments
Based on the progression of test cases, I would guess it is https://github.com/nodejs/nan/blob/master/test/cpp/nannew.cpp#L161 that triggers it, but I do not see why. |
Might no logger be allowed to create empty handles, at least not of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I discovered this while running the
nan
test suite against Electron on our CI (we run tests with DCHECKs enabled). Just to cover my bases I ran the same nan tests against aDebug
build of node and the same DCHECKs were hit.The same tests pass in Release builds (as DCHECKs are disabled) but I think some time should be spent figuring out what is going wrong here as V8 clearly isn't happy with what is happening 🤔
To reproduce with a local build of node with a directory structure of
Note that although the example above uses
HEAD
of node (v13) I have reproed with v12 as well (which is what Electron currently ships)The text was updated successfully, but these errors were encountered: