Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting for JavaScript code #1063

Closed
mhdawson opened this issue Sep 3, 2021 · 5 comments · Fixed by #1067
Closed

Add linting for JavaScript code #1063

mhdawson opened this issue Sep 3, 2021 · 5 comments · Fixed by #1067

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 3, 2021

  • Suggestion is eslint with semistandard
  • Only apply to files that are changed
  • run apply as part of adding, list steps to generate lint changes
  • have second person do run to make sure we don't have unintended changes
@rubiagatra
Copy link
Contributor

Wanna help because this is good first issue, https://www.npmjs.com/package/eslint-config-semistandard using this semistandard?

@mhdawson
Copy link
Member Author

@rubiagatra using eslint with https://www.npmjs.com/package/eslint-config-semistandard is what I had in mind.

@mhdawson
Copy link
Member Author

Thanks for working on this.

@rubiagatra
Copy link
Contributor

Thank you for @mhdawson for your guidance!

For the next step of linting/tooling, should I create the issue?

@mhdawson
Copy link
Member Author

@rubiagatra creating an issue that lists the files (maybe with checkboxes that can be checked when file is completed) which report errors along with the steps/approach for submitting a PR to run the lint fix/submit PR would be useful. Some of things that come to mind for the process would be:

  1. Make small modification to file, run link fix to get updated version
  2. If all required changes are fixed by linter, then open PR state that all changes were generated by --fix
  3. If not all required changes were fixed by linter, then commit those from --fix in first commit. Manually fix the rest and add a second commit with those changes. Open PR with 2 commits, indicating the changes in the first commit were all generated with --fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants