Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release #1278

Closed
mhdawson opened this issue Jan 27, 2023 · 7 comments
Closed

Next release #1278

mhdawson opened this issue Jan 27, 2023 · 7 comments

Comments

@mhdawson
Copy link
Member

We discussed issuing a SemVer major release to address #1272

The fix/tests have landed for that issue but I think we should also land #1266 since we marked that as SemVer major as well.

@nodejs/node-api any others we should try to include?

@NickNaso would you like to do the release?

@NickNaso
Copy link
Member

yes I can. I will make the next release v6.0.0 after the PR #1266 will be landed.

@mhdawson
Copy link
Member Author

@NickNaso thanks!. Just landed #1266

@NickNaso
Copy link
Member

NickNaso commented Feb 3, 2023

I'm starting to work on release v6.0.0.

@Candylong
Copy link

When will the 6.0.0 release be

@NickNaso
Copy link
Member

I think that I found the test that does not work:
https://github.com/nodejs/node-addon-api/blob/main/test/async_progress_worker.cc#L185
https://github.com/nodejs/node-addon-api/blob/main/test/async_progress_worker.js#L12

Anyone have an idea because this test hangs on Node.js v16 and x86 platform?

@NickNaso
Copy link
Member

The new release has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants