Internal/external selection broken for latest 6.x release

[mhdawson]

Looks like this logic in 437514e

Is not quite right:

var isNodeApiBuiltin = (
  versionArray[0] > 8 ||
  (versionArray[0] == 8 && versionArray[1] >= 6) ||
  (versionArray[0] == 6 && versionArray[1] >= 14 && versionArray[2] >= 2));

[mhdawson]

Branch with test fix here: https://github.com/mhdawson/node-addon-api/tree/fixselection

[mhdawson]

PR for fix: #402

@NickNaso if you have time we probably want to plan a release with this fix. As of the security releases earlier this week and the bump of 6.14 -> 6.15 node-addon-api is broken for the 6.X line.

[NickNaso]

Hi @mhdawson I will provide to open an issue with the intention on making new release v1.6.2.

[mhdawson]

@NickNaso thanks. Landed PR and just running CI job to validate all is resolved:

https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/

[mhdawson]

CI run looks good closing.