chakrashim: add dummy shim for v8::ScriptOrModule and v8::Isolate::SetHostImportModuleDynamicallyCallback

Author: boingoing

deps/chakrashim/chakrashim.gyp

@@ -150,6 +150,7 @@
         'src/v8proxy.cc',
         'src/v8regexp.cc',
         'src/v8script.cc',
+        'src/v8scriptormodule.cc',
         'src/v8sharedarraybuffer.cc',
         'src/v8set.cc',
         'src/v8signature.cc',

deps/chakrashim/include/v8.h

@@ -134,6 +134,7 @@ class Promise;
 class PropertyDescriptor;
 class Proxy;
 class Script;
+class ScriptOrModule;
 class Signature;
 class StartupData;
 class StackFrame;
@@ -268,6 +269,9 @@ typedef bool (*EntropySource)(unsigned char* buffer, size_t length);
 typedef void (*FatalErrorCallback)(const char *location, const char *message);
 typedef void (*JitCodeEventHandler)(const JitCodeEvent *event);
 
+typedef MaybeLocal<Promise>(*HostImportModuleDynamicallyCallback)(
+    Local<Context> context, Local<ScriptOrModule> referrer,
+    Local<String> specifier);
 
 template <class T>
 class Local {
@@ -838,6 +842,11 @@ class V8_EXPORT Data {
  public:
 };
 
+class V8_EXPORT ScriptOrModule {
+public:
+    Local<Value> GetResourceName();
+};
+
 class ScriptOrigin {
  public:
   explicit ScriptOrigin(
@@ -2681,6 +2690,9 @@ class V8_EXPORT Isolate {
   void SetAbortOnUncaughtExceptionCallback(
     AbortOnUncaughtExceptionCallback callback);
 
+  void SetHostImportModuleDynamicallyCallback(
+      HostImportModuleDynamicallyCallback callback);
+
   void Enter();
   void Exit();
   void Dispose();

deps/chakrashim/src/v8scriptormodule.cc

@@ -0,0 +1,27 @@
+// Copyright Microsoft. All rights reserved.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files(the "Software"), to
+// deal in the Software without restriction, including without limitation the
+// rights to use, copy, modify, merge, publish, distribute, sublicense, and / or
+// sell copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions :
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+
+#include "v8chakra.h"
+
+namespace v8 {
+    Local<Value> ScriptOrModule::GetResourceName() {
+        return Local<Value>();
+    }
+}  // namespace v8

deps/chakrashim/src/v8v8.cc

@@ -91,6 +91,11 @@ const char *V8::GetVersion() {
   return versionStr;
 }
 
+void Isolate::SetHostImportModuleDynamicallyCallback(
+    HostImportModuleDynamicallyCallback callback) {
+  // CHAKRA-TODO
+}
+
 void Isolate::SetFatalErrorHandler(FatalErrorCallback that) {
   // CONSIDER: Ignoring for now, since we don't have an equivalent concept.
 }

test/es-module/es-module.status

@@ -10,6 +10,7 @@ prefix es-module
 # These tests are failing for Node-Chakracore and should eventually be fixed
 test-esm-basic-imports : SKIP
 test-esm-double-encoding : SKIP
+test-esm-dynamic-import : SKIP
 test-esm-encoded-path : SKIP
 test-esm-encoded-path-native : SKIP
 test-esm-example-loader : SKIP