chakrashim: fixing lazy interceptor instantiation

MSLaguana · MSLaguana · commit 321e4a1b11b0 · 2017-11-14T15:46:53.000-08:00
diff --git a/deps/chakrashim/src/v8objecttemplate.cc b/deps/chakrashim/src/v8objecttemplate.cc
@@ -987,6 +987,7 @@ void ObjectTemplate::SetNamedPropertyHandler(
   SetterGetterInterceptor * sgi = objectTemplateData->setterGetterInterceptor;
   if (sgi == nullptr) {
     sgi = new SetterGetterInterceptor();
+    objectTemplateData->setterGetterInterceptor = sgi;
   }
   sgi->namedPropertyGetter = getter;
   sgi->namedPropertySetter = setter;
@@ -1025,9 +1026,10 @@ void ObjectTemplate::SetIndexedPropertyHandler(
     return;
   }
 
-  auto sgi = objectTemplateData->setterGetterInterceptor;
+  SetterGetterInterceptor * sgi = objectTemplateData->setterGetterInterceptor;
   if (sgi == nullptr) {
     sgi = new SetterGetterInterceptor();
+    objectTemplateData->setterGetterInterceptor = sgi;
   }
   sgi->indexedPropertyGetter = getter;
   sgi->indexedPropertySetter = setter;

Original file line number	Diff line number	Diff line change
`@@ -987,6 +987,7 @@ void ObjectTemplate::SetNamedPropertyHandler(`
`987`	`987`	`SetterGetterInterceptor * sgi = objectTemplateData->setterGetterInterceptor;`
`988`	`988`	`if (sgi == nullptr) {`
`989`	`989`	`sgi = new SetterGetterInterceptor();`
	`990`	`+ objectTemplateData->setterGetterInterceptor = sgi;`
`990`	`991`	`}`
`991`	`992`	`sgi->namedPropertyGetter = getter;`
`992`	`993`	`sgi->namedPropertySetter = setter;`
`@@ -1025,9 +1026,10 @@ void ObjectTemplate::SetIndexedPropertyHandler(`
`1025`	`1026`	`return;`
`1026`	`1027`	`}`
`1027`	`1028`
`1028`		`- auto sgi = objectTemplateData->setterGetterInterceptor;`
	`1029`	`+ SetterGetterInterceptor * sgi = objectTemplateData->setterGetterInterceptor;`
`1029`	`1030`	`if (sgi == nullptr) {`
`1030`	`1031`	`sgi = new SetterGetterInterceptor();`
	`1032`	`+ objectTemplateData->setterGetterInterceptor = sgi;`
`1031`	`1033`	`}`
`1032`	`1034`	`sgi->indexedPropertyGetter = getter;`
`1033`	`1035`	`sgi->indexedPropertySetter = setter;`