Merge nodejs/master

Merge 896eaf6 as of 2017-10-29.
This is an automatically created merge. For any problems please
contact @kunalspathak.

Author: chakrabot

CONTRIBUTING.md

@@ -309,8 +309,8 @@ notes about [commit squashing](#commit-squashing)).
 A good commit message should describe what changed and why.
 
 1. The first line should:
-   - contain a short description of the change
-   - be 50 characters or less
+   - contain a short description of the change (preferably 50 characters or less,
+     and no more than 72 characters)
    - be entirely in lowercase with the exception of proper nouns, acronyms, and
    the words that refer to code, like function/variable names
    - be prefixed with the name of the changed subsystem and start with an

Makefile

@@ -213,15 +213,26 @@ test: all
 	$(MAKE) build-addons
 	$(MAKE) build-addons-napi
 	$(MAKE) doc-only
+	$(MAKE) lint
 	$(MAKE) cctest
 	$(PYTHON) tools/test.py --mode=release --flaky-tests=$(FLAKY_TESTS) -J \
 		$(CI_ASYNC_HOOKS) \
 		$(CI_JS_SUITES) \
 		$(CI_NATIVE_SUITES) \
 		doctool known_issues
-	$(MAKE) lint
 endif
 
+# For a quick test, does not run linter or build doc
+test-only: all
+	$(MAKE) build-addons
+	$(MAKE) build-addons-napi
+	$(MAKE) cctest
+	$(PYTHON) tools/test.py --mode=release -J \
+		$(CI_ASYNC_HOOKS) \
+		$(CI_JS_SUITES) \
+		$(CI_NATIVE_SUITES) \
+		known_issues
+
 test-cov: all
 	$(MAKE) build-addons
 	$(MAKE) build-addons-napi
@@ -1107,6 +1118,7 @@ endif
   test-gc \
   test-gc-clean \
   test-hash-seed \
+  test-only \
   test-v8 \
   test-v8-all \
   test-v8-benchmarks \

benchmark/util/format.js

@@ -21,6 +21,9 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, type }) {
+  // For testing, if supplied with an empty type, default to string.
+  type = type || 'string';
+
   const [first, second] = inputs[type];
 
   bench.start();

benchmark/util/inspect-array.js

@@ -18,6 +18,9 @@ function main({ n, len, type }) {
   var arr = Array(len);
   var i, opts;
 
+  // For testing, if supplied with an empty type, default to denseArray.
+  type = type || 'denseArray';
+
   switch (type) {
     case 'denseArray_showHidden':
       opts = { showHidden: true };

benchmark/util/type-check.js

@@ -29,16 +29,19 @@ const bench = common.createBenchmark(main, {
   type: Object.keys(args),
   version: ['native', 'js'],
   argument: ['true', 'false-primitive', 'false-object'],
-  millions: ['5']
+  n: [5e6]
 }, {
   flags: ['--expose-internals']
 });
 
 function main(conf) {
+  // For testing, if supplied with an empty type, default to ArrayBufferView.
+  conf.type = conf.type || 'ArrayBufferView';
+
   const util = process.binding('util');
   const types = require('internal/util/types');
 
-  const n = (+conf.millions * 1e6) | 0;
+  const n = (+conf.n) | 0;
   const func = { native: util, js: types }[conf.version][`is${conf.type}`];
   const arg = args[conf.type][conf.argument];
 

common.gypi

@@ -29,7 +29,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.7',
+    'v8_embedder_string': '-node.8',
 
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,

deps/v8/include/v8-inspector.h

@@ -211,6 +211,8 @@ class V8_EXPORT V8InspectorClient {
   // TODO(dgozman): this was added to support service worker shadow page. We
   // should not connect at all.
   virtual bool canExecuteScripts(int contextGroupId) { return true; }
+
+  virtual void maxAsyncCallStackDepthChanged(int depth) {}
 };
 
 class V8_EXPORT V8Inspector {

deps/v8/src/inspector/v8-debugger.cc

@@ -726,6 +726,8 @@ void V8Debugger::setAsyncCallStackDepth(V8DebuggerAgentImpl* agent, int depth) {
   if (m_maxAsyncCallStackDepth == maxAsyncCallStackDepth) return;
   // TODO(dgozman): ideally, this should be per context group.
   m_maxAsyncCallStackDepth = maxAsyncCallStackDepth;
+  m_inspector->client()->maxAsyncCallStackDepthChanged(
+      m_maxAsyncCallStackDepth);
   if (!maxAsyncCallStackDepth) allAsyncTasksCanceled();
 }
 

deps/v8/test/inspector/debugger/max-async-call-stack-depth-changed-expected.txt

@@ -0,0 +1,5 @@
+Tests for max async call stack depth changed.
+maxAsyncCallStackDepthChanged: 8
+maxAsyncCallStackDepthChanged: 0
+maxAsyncCallStackDepthChanged: 8
+maxAsyncCallStackDepthChanged: 0

deps/v8/test/inspector/debugger/max-async-call-stack-depth-changed.js

@@ -0,0 +1,16 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+let {session, contextGroup, Protocol} =
+    InspectorTest.start('Tests for max async call stack depth changed.');
+
+(async function test(){
+  utils.setLogMaxAsyncCallStackDepthChanged(true);
+  await Protocol.Debugger.enable();
+  await Protocol.Debugger.setAsyncCallStackDepth({maxDepth: 8});
+  await Protocol.Debugger.setAsyncCallStackDepth({maxDepth: 0});
+  await Protocol.Debugger.setAsyncCallStackDepth({maxDepth: 8});
+  await Protocol.Debugger.disable();
+  InspectorTest.completeTest();
+})();