chakrashim,src: fixed missing shims

* Added IdleTask and TaskRunner
* Re-added v8-debug.h for the chakracore inspector implementation
* Re-added min/max macro fixes to HTTP2
* Fixed cpplint issue around comments

Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>

Author: kfarnung

deps/chakrashim/include/v8-platform.h

@@ -42,6 +42,28 @@ class Task {
   virtual void Run() = 0;
 };
 
+class IdleTask {
+ public:
+  virtual ~IdleTask() = default;
+  virtual void Run(double deadline_in_seconds) = 0;
+};
+
+class TaskRunner {
+ public:
+  virtual void PostTask(std::unique_ptr<Task> task) = 0;
+  virtual void PostDelayedTask(std::unique_ptr<Task> task,
+                               double delay_in_seconds) = 0;
+  virtual void PostIdleTask(std::unique_ptr<IdleTask> task) = 0;
+  virtual bool IdleTasksEnabled() = 0;
+
+  TaskRunner() = default;
+  virtual ~TaskRunner() = default;
+
+ private:
+  TaskRunner(const TaskRunner&) = delete;
+  TaskRunner& operator=(const TaskRunner&) = delete;
+};
+
 /**
 * The interface represents complex arguments to trace events.
 */
@@ -101,6 +123,17 @@ class Platform {
   virtual ~Platform() = default;
 
   virtual size_t NumberOfAvailableBackgroundThreads() { return 0; }
+  
+  virtual std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner(
+      Isolate* isolate) {
+    return {};
+  }
+
+  virtual std::shared_ptr<v8::TaskRunner> GetBackgroundTaskRunner(
+      Isolate* isolate) {
+    return {};
+  }
+
   virtual void CallOnBackgroundThread(Task* task,
                                       ExpectedRuntime expected_runtime) = 0;
   virtual void CallOnForegroundThread(Isolate* isolate, Task* task) = 0;

deps/chakrashim/src/jsrtutils.h

@@ -82,11 +82,11 @@ inline size_t _countof(T (&)[N]) {
 #define CHAKRA_ASSERT(expr) assert(expr)
 #define CHAKRA_UNIMPLEMENTED() jsrt::Unimplemented(__FUNCTION__)
 #define CHAKRA_UNIMPLEMENTED_(message) jsrt::Unimplemented(message)
-#else // DEBUG
+#else  // DEBUG
 #define CHAKRA_UNIMPLEMENTED()         /* no-op */
 #define CHAKRA_UNIMPLEMENTED_(message) /* no-op */
 #define CHAKRA_ASSERT(expr)            /* no-op */
-#endif // DEBUG
+#endif  // DEBUG
 
 #define CHAKRA_VERIFY(expr) if (!(expr)) { \
   jsrt::Fatal("internal error %s(%d): %s", __FILE__, __LINE__, #expr); }

src/node.cc

@@ -67,6 +67,7 @@
 #if NODE_USE_V8_PLATFORM
 #include "libplatform/libplatform.h"
 #endif  // NODE_USE_V8_PLATFORM
+#include "v8-debug.h"
 #include "v8-profiler.h"
 #include "zlib.h"
 

src/node_http2.cc

@@ -5,6 +5,14 @@
 #include "node_http2_state.h"
 
 #include <queue>
+
+// min and max are defined in the PAL, which interferes
+// with <algorithm>'s std::min and std::max
+#ifdef NODE_ENGINE_CHAKRACORE
+#undef min
+#undef max
+#endif
+
 #include <algorithm>
 
 namespace node {