Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: fixed test case for v8
Browse files Browse the repository at this point in the history
Fixes: #354
PR-URL: #355
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
  • Loading branch information
kunalspathak authored and kfarnung committed Aug 14, 2017
1 parent 39876b5 commit d934b66
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
19 changes: 9 additions & 10 deletions test/message/nexttick_throw.v8.out
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@

*test*message*nexttick_throw.js:*
*undefined_reference_error_maker;
*^
ReferenceError: *undefined_reference_error_maker*
*at *test*message*nexttick_throw.js:*:*
*at _combinedTickCallback (internal/process/next_tick.js:*:*)
*at *_tickCallback (internal/process/next_tick.js:*:*)
*at Module.runMain (module.js:*:*)
*at run (bootstrap_node.js:*:*)
*at startup (bootstrap_node.js:*:*)
*at *bootstrap_node.js:*:*
undefined_reference_error_maker;
^
ReferenceError: undefined_reference_error_maker is not defined
at *test*message*nexttick_throw.js:*:*
at _combinedTickCallback (internal/process/next_tick.js:*:*)
at process._tickCallback (internal/process/next_tick.js:*:*)
at Function.Module.runMain (module.js:*:*)
at startup (bootstrap_node.js:*:*)
at bootstrap_node.js:*:*
6 changes: 3 additions & 3 deletions test/parallel/test-vm-new-script-new-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const Script = require('vm').Script;
},
common.engineSpecificMessage({
v8: /^ReferenceError: foo is not defined$/,
chakracore: /undefined or null/
chakracore: /^TypeError: Unable to set property 'bar' of undefined or null reference$/
})
);
}
Expand Down Expand Up @@ -106,7 +106,7 @@ const Script = require('vm').Script;
},
common.engineSpecificMessage({
v8: /^ReferenceError: f is not defined$/,
chakracore: /'a' of undefined or null/
chakracore: /^TypeError: Unable to set property 'a' of undefined or null reference$/
})
);
}
Expand All @@ -117,6 +117,6 @@ const Script = require('vm').Script;
script.runInNewContext.call('\'hello\';');
}, common.engineSpecificMessage({
v8: /^TypeError: this\.runInContext is not a function$/,
chakracore: /TypeError: Object doesn't support property or method 'runInContext'/
chakracore: /^TypeError: Object doesn't support property or method 'runInContext'$/
}));
}

0 comments on commit d934b66

Please sign in to comment.