Build failure with Microsoft Visual C++ Build Tools 2015

[joaocgreis]

This issue replaces "building with Microsoft Visual C++ Build Tools 2015 Technical Preview" (#24). That issue no longer exists, most likely because the account that was used to create it was deleted (user dn7q3b).

• Version: xplat at a35216f
• Platform: Windows with Visual C++ Build Tools 2015
• Subsystem: chakrashim

Console output shows 30 occurrences of:

c:\workspace\node-compile-windows\label\win-vcbt2015\deps\chakrashim\core\lib\runtime\Base/DelayLoadLibrary.h(14): fatal error C1083: Cannot open include file: 'cor.h': No such file or directory

All 30 errors are in DelayLoadLibrary: https://github.com/nodejs/node-chakracore/blob/a35216f4/deps/chakrashim/core/lib/Runtime/Base/DelayLoadLibrary.h#L14

[digitalinfinity]

@joaocgreis the CI build does pass- https://ci.nodejs.org/view/All/job/chakracore-test-windows/46/

However, I see test failures in this log: https://ci.nodejs.org/job/node-test-binary-windows/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2012r2/7288/console

Is this the same issue as nodejs/node#10286?

[joaocgreis]

That failure was with binaries compiled by VS2015, not VCBT, so it's unrelated. The failure is in parallel/test-http-client-get-url so it's not the same as nodejs/node#10286, but might have the same root cause. This looks like a one off to me.

I am positive that your changes fix this issue.

[joaocgreis]

Fixed by #203