Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add travis build checks to git-node-land #375

Closed
sam-github opened this issue Nov 15, 2019 · 1 comment
Closed

add travis build checks to git-node-land #375

sam-github opened this issue Nov 15, 2019 · 1 comment

Comments

@sam-github
Copy link
Contributor

#369 is a round-about way of doing it, but apparently not reliable (#369 (comment)). If it was reliable, then all the specific code to check Jenkins or Travis would be unnecessary, so that's unfortunate.

Note that since nodejs/node#30330 only Travis has been required for doc-only tests.

There have also been musings (some by me) of using Travis more for actual CI testing:

This would require Travis failures to block landing PRs.

@codebytere
Copy link
Member

Closing as Node.js PRs now use Jenkins and GitHub actions, checks for both of which are included in git-node-land logic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants