Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncu-ci pr failed #452

Closed
gengjiawen opened this issue Jun 30, 2020 · 7 comments · Fixed by #451
Closed

ncu-ci pr failed #452

gengjiawen opened this issue Jun 30, 2020 · 7 comments · Fixed by #451

Comments

@gengjiawen
Copy link
Member

gengjiawen commented Jun 30, 2020

On latest commit for PR: nodejs/node#34086 (comment)

ncu-ci pr 34086
--------------------------------------------------------------------------------
[1/1] Running PR: 34086
--------------------------------------------------------------------------------
✔  Build data downloaded
TypeError: Cannot read property 'find' of undefined
    at PRBuild.setBuildData (/usr/local/lib/node_modules/node-core-utils/lib/ci/ci_result_parser.js:208:28)
    at PRBuild.getResults (/usr/local/lib/node_modules/node-core-utils/lib/ci/ci_result_parser.js:682:10)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async JobCommand.drain (/usr/local/lib/node_modules/node-core-utils/bin/ncu-ci:198:7)
    at async main (/usr/local/lib/node_modules/node-core-utils/bin/ncu-ci:369:3)
@codebytere
Copy link
Member

@gengjiawen this'll be closed by #451

@gengjiawen
Copy link
Member Author

@gengjiawen this'll be closed by #451

But this has been runs by jenkins QUIC CI: ci.nodejs.org/job/node-test-commit/39325

@codebytere
Copy link
Member

codebytere commented Jun 30, 2020

@gengjiawen hmm - the error is the same as the one fixed above:

{
  servlet: 'Stapler',
  message: 'Not Found',
  url: '/job/node-test-pull-request/39325/api/json',
  status: '404'
}

is what's returned by the API

@codebytere
Copy link
Member

codebytere commented Jun 30, 2020

perhaps a daft question but what's different about the QUIC CI? it looks like the same UI and tests being run but logically i assume there's something different in build params 🤔

Edit: looks like just --experimental-quic flag?

@richardlau
Copy link
Member

nodejs/node#34086 (comment) doesn't have a node-test-pull-request run. The QUIC CI link is directly running node-test-commit because it uses non-standard config flags to build.

@gengjiawen
Copy link
Member Author

nodejs/node#34086 (comment) doesn't have a node-test-pull-request run. The QUIC CI link is directly running node-test-commit because it uses non-standard config flags to build.

https://github.com/nodejs/node-core-utils/blob/master/docs/ncu-ci.md

This page says

Supported jobs:

node-test-pull-request
node-test-commit
benchmark-node-micro-benchmarks

Is it outdated ?

@codebytere
Copy link
Member

codebytere commented Jun 30, 2020

@gengjiawen you need to run ncu-ci commit <jobid> for node-test-commit

For https://ci.nodejs.org/job/node-test-commit/39325/ if i run ncu-ci commit 39325 i get

node on git:v14.5.0-proposal ❯ ncu-ci commit 39325                             7:34AM
--------------------------------------------------------------------------------
[1/1] Running COMMIT: 39325
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/node-test-commit/39325/
Source     https://github.com/nodejs/node/pull/34086/
Commit     [725a1df7b849] quic: remove redundant cast
Date       2020-06-27 22:14:09 +0800
Author     Jiawen Geng <technicalcute@gmail.com>
----------------------------------- osx1014 ------------------------------------
URL        https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1014/34964/console
Type       JS_TEST_FAILURE
Built On   test-orka-macos10.14-x64-2
Reason     
  not ok 1694 parallel/test-quic-statelessreset
    ---
    duration_ms: 0.432
    severity: fail
    exitcode: 1
    stack: |-
      assert.js:103
        throw new AssertionError(obj);
        ^
      
      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
      
      2n !== 1n
      
          at QuicSocket.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1014/test/parallel/test-quic-statelessreset.js:47:10)
          at QuicSocket.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1014/test/common/index.js:365:15)
          at QuicSocket.emit (events.js:314:20)
          at processTicksAndRejections (internal/process/task_queues.js:75:11) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: 2n,
        expected: 1n,
        operator: 'strictEqual'
      }
    ...
  
--------------------- ubi81_sharedlibs_openssl111fips_x64 ----------------------
URL        https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubi81_sharedlibs_openssl111fips_x64/21043/console
Type       BUILD_FAILURE
Built On   test-digitalocean-ubi81_container-x64-2
Reason     
  make: *** [Makefile:547: build-ci] Error 1
  Build step 'Conditional steps (multiple)' marked build as failure
  All downstream projects complete!
  Performing Post build task...
--------------------- ubuntu1804_sharedlibs_openssl111_x64 ---------------------
URL        https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_openssl111_x64/21043/console
Type       BUILD_FAILURE
Built On   test-digitalocean-ubuntu1804_sharedlibs_container-x64-5
Reason     
  Makefile:547: recipe for target 'build-ci' failed
  make: *** [build-ci] Error 1
  Build step 'Conditional steps (multiple)' marked build as failure
  All downstream projects complete!
  Performing Post build task...
  Match found for : : True
--------------------- ubuntu1804_sharedlibs_withoutssl_x64 ---------------------
URL        https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/21043/console
Type       BUILD_FAILURE
Built On   test-softlayer-ubuntu1804_sharedlibs_container-x64-5
Reason     
  ERROR: --without-ssl is incompatible with --experimental-quic
  Makefile:547: recipe for target 'build-ci' failed
  make: *** [build-ci] Error 1
  Build step 'Conditional steps (multiple)' marked build as failure
  All downstream projects complete!
  Performing Post build task...
--------------------------------- Other builds ---------------------------------
Unstable   https://ci.nodejs.org/job/node-test-commit-linux/35821/
Unstable   https://ci.nodejs.org/job/node-test-commit-arm-fanned/15098/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants