-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse ci failure error #640
Conversation
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 37 37
Lines 4074 4074
=======================================
Hits 3426 3426
Misses 648 648
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
probably best to add a test here? https://github.com/nodejs/node-core-utils/blob/main/test/unit/ci_failure_parser.test.js
I will add a test for this fix. |
of course. I am working on the test. this is why this pr is a draft.😀 |
de00536
to
75ef933
Compare
I added a test for the fix, please take another look. |
acaf341
to
3c634d6
Compare
3c634d6
to
4cdb536
Compare
@aduh95 could you help to merge this pr? |
Update CI reliability job stop working again, please help to merge this pr, Thank you! https://github.com/nodejs/reliability/runs/7587812485?check_suite_focus=true cc @nodejs/node-core-utils |
fix #639