Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo: account LGTM in "COMMENTED" reviews #67

Closed
joyeecheung opened this issue Nov 4, 2017 · 4 comments
Closed

todo: account LGTM in "COMMENTED" reviews #67

joyeecheung opened this issue Nov 4, 2017 · 4 comments
Assignees
@Tiriel
Labels
feature request New features for node-core-utils

Comments

@joyeecheung
Copy link
Member

Example: nodejs/node#16248 (review)
@joyeecheung joyeecheung added the feature request New features for node-core-utils label Nov 4, 2017
@joyeecheung joyeecheung changed the title account LGTM in "COMMENTED" reviews todo: account LGTM in "COMMENTED" reviews Nov 4, 2017
@Tiriel
Copy link
Contributor

Tiriel commented Nov 4, 2017

Just to be sure, you want to count the number of "LGTM" in the comments of a review?

Anyway, I'm taking this one!

@joyeecheung
Copy link
Member Author

@Tiriel I mean the LGTM in a COMMENTED review should count as an approval ;)

@Tiriel
Copy link
Contributor

Tiriel commented Nov 4, 2017

Oh yeah I see, sorry.

Got it! I'll assign myself if it's ok

@Tiriel Tiriel self-assigned this Nov 4, 2017
@Tiriel Tiriel mentioned this issue Nov 4, 2017
Merged
@joyeecheung joyeecheung added the Work In Progress PR's that are in progress label Nov 5, 2017
@Tiriel
Copy link
Contributor

Tiriel commented Nov 8, 2017

Landed in #72 !

@Tiriel Tiriel closed this as completed Nov 8, 2017
@Tiriel Tiriel removed the Work In Progress PR's that are in progress label Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tiriel Tiriel

Labels
feature request New features for node-core-utils
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joyeecheung @Tiriel