Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct V8 tag for major updates #675

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

targos
Copy link
Member

@targos targos commented Feb 27, 2023

Sometimes there might be additional tags with suffix such as -pgo

Sometimes there might be additional tags with suffix such as `-pgo`
@targos
Copy link
Member Author

targos commented Feb 27, 2023

Fixes: https://github.com/nodejs/node-v8/actions/runs/4279399575/jobs/7450060217

[STARTED] Checkout V8 branch
[FAILED] Command failed with exit code 128: git branch 11.3.10-pgo origin/11.3.10-pgo
[FAILED] fatal: not a valid object name: 'origin/11.3.10-pgo'
[FAILED] Command failed with exit code 128: git branch 11.3.10-pgo origin/11.3.10-pgo
[FAILED] fatal: not a valid object name: 'origin/11.3.10-pgo'
✖ Command failed with exit code 128: git branch 11.3.10-pgo origin/11.3.10-pgo
fatal: not a valid object name: 'origin/11.3.10-pgo'

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 83.41% // Head: 83.41% // No change to project coverage 👍

Coverage data is based on head (855e84d) compared to base (64f6a1c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          37       37           
  Lines        4136     4136           
=======================================
  Hits         3450     3450           
  Misses        686      686           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos targos merged commit ebcf18e into nodejs:main Feb 27, 2023
@targos targos deleted the v8-tag branch February 27, 2023 15:11
targos added a commit to targos/node-core-utils that referenced this pull request Apr 13, 2023
targos added a commit that referenced this pull request Apr 16, 2023
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants