Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 commands are broken #723

Closed
targos opened this issue Sep 6, 2023 · 1 comment · Fixed by #726 or #728
Closed

V8 commands are broken #723

targos opened this issue Sep 6, 2023 · 1 comment · Fixed by #726 or #728

Comments

@targos
Copy link
Member

targos commented Sep 6, 2023

#722 (comment)

See https://github.com/nodejs/node-v8/actions/runs/6093305552/job/16532764329

I do not have time to fix it until next week.
@targos targos mentioned this issue Sep 11, 2023
Closed
@aduh95 aduh95 mentioned this issue Sep 11, 2023
Merged
@targos
Copy link
Member Author

targos commented Sep 13, 2023

Backport command is still broken:

$ git node v8 --v8-dir ~/git/chromium/v8/v8 backport 1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7
✔ Update local V8 clone
⠋ V8 commit backport

Exit code: 1

@targos targos reopened this Sep 13, 2023
@aduh95 aduh95 mentioned this issue Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@targos