Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prompt dependency updates url in vulnerabilities.json creation #788

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Mar 26, 2024

Fixes: https://github.com/nodejs-private/security-release/issues/9
Also we prompt for the release date for the issue, it makes sense to add it to the vulnerabilities.json, if it doesnt change you dont have to do anything, if it changes you would have to update it either way.

I think I should also create an automation to add/remove them.

cc @RafaelGSS

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (8a04848) to head (95b8455).

❗ Current head 95b8455 differs from pull request most recent head 1ad27f8. Consider uploading reports for the commit 1ad27f8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files          37       37           
  Lines        4200     4200           
=======================================
  Hits         3485     3485           
  Misses        715      715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/prepare_security.js Outdated Show resolved Hide resolved
@marco-ippolito
Copy link
Member Author

@RafaelGSS this is ready to land

@RafaelGSS RafaelGSS merged commit f521793 into nodejs:main Apr 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants