-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using tape for tests #1123
Comments
or we could stop monkey patching or do proper isolation with child processes as required |
Another reason to stop using tape -- The test failure in #1131 actually stopped the test execution dead in its tracks (i.e. no further tests were run), e.g. https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/118/MACHINE=aix61-ppc64/console |
Tap would be largely a drop-in replacement and runs each of the test files as separate child processes. |
We already use tap for node-report, citgm, and npm, so it would probably make sense to use it here as well. |
moving to #1171 |
Tape runs all tests in the same process. There doesn't seem to be a way to request process-per-test isolation.
Monkey-patching in tests ends up affecting other tests. I'm quite sure at least one or two bugs (hopefully only in tests) went unnoticed because of it so I propose we move away from tape.
The text was updated successfully, but these errors were encountered: