Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title mismatch the content in docs #2573

Closed
owl-from-hogvarts opened this issue Dec 15, 2021 · 1 comment
Closed

Title mismatch the content in docs #2573

owl-from-hogvarts opened this issue Dec 15, 2021 · 1 comment

Comments

@owl-from-hogvarts
Copy link
Contributor

Short summary: The content of this docs page from before this PR had steps that work in npm 7. Please host/restore the old content of this docs page somewhere. Furthermore, this PR caused the title/filename to not match the content. Please make it so the titles/filenames match the content.


Also: The title and filename of this do not match the content anymore, as of this PR. This advice is more about "Having npm use an independent copy of node-gyp instead of its bundled copy".

The title ("Updating the npm-bundled version of node-gyp") matches the previous content.

I would request that the previous content of this file be hosted somewhere in the docs... Preferably under this filename, to make the edit history follow-able. (In other words, please consider restoring the previous content of this file, and moving the new content to another file.)

I would humbly suggest to move the updated content to a new file, under an appropriate filename and title, with the understanding that it applies ONLY to npm 6 and lower, and saying so somewhere in this file, so users don't get surprised when it doesn't work in npm 7 or higher.

The method described as of this PR is a more durable, maybe less hacky fix for npm 6 users. So I do like this method. It's just a minor disappointment it doesn't work on newer npm right now.

Originally posted by @DeeDeeG in #2448 (comment)

@owl-from-hogvarts owl-from-hogvarts changed the title Short summary: **The content of this docs page from before this PR had steps that work in npm 7. Please host/restore the old content of this docs page somewhere. Furthermore, this PR caused the title/filename to not match the content. Please make it so the titles/filenames match the content.** Title missmatch the content in docs Dec 15, 2021
@cclauss cclauss changed the title Title missmatch the content in docs Title mismatch the content in docs Dec 16, 2021
@owl-from-hogvarts
Copy link
Contributor Author

PR dedicated to fix this issue is merged, so i am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant