-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop npm config set
support
#2879
Comments
Is removing things that no longer work from the docs a breaking change? Perhaps doc edits could be separated from other methods of setting items. |
FWIW the relevant code is: Lines 134 to 156 in 53c99ae
Removing that would be semver major for node-gyp. While npm 9 may no longer be setting We could, for example keep the above code and this documentation Lines 224 to 241 in 53c99ae
Lines 243 to 254 in 53c99ae
|
Good points @cclauss and @richardlau. Here's what I'm thinking now:
Then this is no longer a breaking change. My main goal is to not have |
npm 9 no longer supports setting arbitrary config items. This should be removed from the docs, with the other methods of setting items such as environs being the ideal solution.
This is a breaking change so it is good timing to make this change along with the breaking engine changes that already landed.
Ref #2798 #2800
The text was updated successfully, but these errors were encountered: