This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Commit fed9753
committed
fix: Fix
Fix a logic bug in `takeHeapSnapshot()` where it interpreted the item
count as the byte count, resulting in truncated snapshots.
This change hinges on the observation that the completion callback
always comes after any and all `'addHeapSnapshotChunk'` events.
I'm 95% sure after digging into the V8 inspector and its integration
with Node.js that the assumption above is correct.
If it turns out I'm mistaken, then we will most likely treat that as
a bug in Node.js, not node-inspect.
Fixes: #56takeHeapSnapshot() truncation bug1 parent a0b38c0 commit fed9753
2 files changed
+44
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
900 | 900 | | |
901 | 901 | | |
902 | 902 | | |
903 | | - | |
904 | 903 | | |
905 | 904 | | |
906 | | - | |
907 | 905 | | |
908 | 906 | | |
909 | 907 | | |
| |||
913 | 911 | | |
914 | 912 | | |
915 | 913 | | |
916 | | - | |
917 | | - | |
918 | | - | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
919 | 918 | | |
920 | 919 | | |
921 | 920 | | |
922 | | - | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
923 | 926 | | |
924 | 927 | | |
925 | 928 | | |
| |||
932 | 935 | | |
933 | 936 | | |
934 | 937 | | |
935 | | - | |
936 | | - | |
937 | | - | |
938 | | - | |
| 938 | + | |
939 | 939 | | |
940 | 940 | | |
941 | 941 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
0 commit comments