Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Moving node-report into core #110

Closed
mhdawson opened this issue Apr 12, 2018 · 3 comments
Closed

Moving node-report into core #110

mhdawson opened this issue Apr 12, 2018 · 3 comments

Comments

@mhdawson
Copy link
Member

In the diagnostic summit the consensus was to move node-report into core (not as a module but fully integrated).

@richardlau we should set up a time to discuss and if possible document the timeline to do that.

@mhdawson
Copy link
Member Author

I know this is open nodejs/node#19661 but I believe that is to add it as a dependency.

@joyeecheung
Copy link
Member

I believe during the diagnostics summit we were talking about exposing it via util because adding an additional module comes with more implications than putting it under an existing one. There is also the question of how it should be enabled in core, nodejs/node#19661 currently enables it when there are fatal errors or SIGUSR2 sent, but that might be conflicting with user land modules.

@richardlau
Copy link
Member

nodejs/node#22712 has been merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants