Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on pull requests that don't have the mergeability-details container at the bottom #1

Closed
evanlucas opened this issue Oct 8, 2016 · 4 comments
Closed

Doesn't work on pull requests that don't have the mergeability-details container at the bottom #1

evanlucas opened this issue Oct 8, 2016 · 4 comments

Comments

@evanlucas
Copy link
Contributor

With the transition to the new review based system, some pull requests do not have a div with the mergeability-details class. This class is what we currently use for the new reviews.

A workaround could be to look in the comments that are approval comments?
@thefourtheye
Copy link

You mean when there is a merge conflict?

@evanlucas
Copy link
Contributor Author

No, there are a few pull requests that I tried it on that did not have the container at the bottom of the PR. Now that I am trying to find one though, I'm having trouble. I'll keep looking and update when I do find one.

@evanlucas
Copy link
Contributor Author

ok, so I'm really not sure what's going on now as nodejs/node#9041 works in Chrome 52, but doesn't show all reviewers in Chrome 53. I'll keep digging

@evanlucas
Copy link
Contributor Author

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanlucas @thefourtheye