Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: remove LGTM approvals on new commit #12

Open
refack opened this issue Jun 7, 2017 · 1 comment
Open

feature request: remove LGTM approvals on new commit #12

refack opened this issue Jun 7, 2017 · 1 comment

Comments

@refack
Copy link
Contributor

refack commented Jun 7, 2017

As per https://github.com/nodejs/node/pull/13413/files#r120732145 we could enable people to conditionally approve by using the LGTM comment (instead on GitHub's Approval).
That is:

  • People who use GitHub Approval defer to the lander.
  • People who opt to comment LGTM want to be dismissed if a new commit is added after their comment.

I'll open a PR myself, I just wanted to record this feature request
@refack refack mentioned this issue Jun 7, 2017
Closed
@legendecas
Copy link
Member

GitHub now has an option to dismiss all approvals on new commits. Though it might be too aggressive to apply the rule on all reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refack @legendecas