Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

src: kill off node_isolate #6899

Closed
bnoordhuis opened this issue Jan 17, 2014 · 3 comments
Closed

src: kill off node_isolate #6899

bnoordhuis opened this issue Jan 17, 2014 · 3 comments
Assignees
Milestone

Comments

@bnoordhuis
Copy link
Member

Continued from #6897. If node wants to grow multi-isolate powers, then node_isolate needs to go. In most places you can trivially replace it with args.GetIsolate() but not everywhere.

Performance impact: args.GetIsolate() is eminently inline-able so the impact should be close or equal to zero.

/cc @indutny

@indutny
Copy link
Member

indutny commented Jan 17, 2014

And here #1 comes: #6901

@ghost ghost assigned indutny Jan 28, 2014
@indutny
Copy link
Member

indutny commented Jan 28, 2014

It is rather problematic to do it fully now, but I'll do my best to at least remove it in all obvious places.

@indutny
Copy link
Member

indutny commented Jan 28, 2014

And just to record the idea: env->Throw(...) and friends.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants