-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build issue with inspector protocol #217
Comments
Is this the cause of no canary binaries since 10-Jan-2022? |
Probably. |
I don't know how to handle this correctly on our side, so I'm going to float a patch that adds the field back to inspector_protocol_config.json. |
Actually, I found the solution in the Bazel file 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/nodejs/node-v8/runs/4849367189?check_suite_focus=true
It seems that the
path
property is added from the build file: https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/src/inspector/BUILD.gn#51Introduced in https://chromium.googlesource.com/v8/v8.git/+/db77f7fb4acbc7d75fbacbcaed8ded4e36be457f
The text was updated successfully, but these errors were encountered: