Skip to content

Commit

Permalink
deps: V8: template explicit instantiation for GCC-8
Browse files Browse the repository at this point in the history
Fails to link for missing:
void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...)

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
refack authored and targos committed Jun 4, 2019
1 parent b411114 commit 0a5ff4c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.9',
'v8_embedder_string': '-node.10',

##### V8 defaults for Node.js #####

Expand Down
5 changes: 5 additions & 0 deletions deps/v8/src/elements.cc
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@
namespace v8 {
namespace internal {

// Explicit instantiation declarations.
extern template void JSObject::ApplyAttributesToDictionary(
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
const PropertyAttributes attributes);


namespace {

Expand Down
5 changes: 5 additions & 0 deletions deps/v8/src/objects/js-objects.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5836,5 +5836,10 @@ Handle<String> JSMessageObject::GetSourceLine() const {
return isolate->factory()->NewSubString(src, info.line_start, info.line_end);
}

// Explicit instantiation definitions.
template void JSObject::ApplyAttributesToDictionary(
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
const PropertyAttributes attributes);

} // namespace internal
} // namespace v8

0 comments on commit 0a5ff4c

Please sign in to comment.