Skip to content

Commit

Permalink
Revert "deps: V8: forward declaration of Rtl*FunctionTable"
Browse files Browse the repository at this point in the history
This reverts commit 01bc8e6.

PR-URL: #45119
Refs: #45118
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos authored and RafaelGSS committed Nov 10, 2022
1 parent 1bc84ce commit 0a6ed6f
Showing 2 changed files with 1 addition and 31 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.16',
'v8_embedder_string': '-node.17',

##### V8 defaults for Node.js #####

30 changes: 0 additions & 30 deletions deps/v8/src/diagnostics/unwinding-info-win64.cc
Original file line number Diff line number Diff line change
@@ -21,36 +21,6 @@
// This has to come after windows.h.
#include <versionhelpers.h> // For IsWindows8OrGreater().

// Forward declaration to keep this independent of Win8
NTSYSAPI
DWORD
NTAPI
RtlAddGrowableFunctionTable(
_Out_ PVOID* DynamicTable,
_In_reads_(MaximumEntryCount) PRUNTIME_FUNCTION FunctionTable,
_In_ DWORD EntryCount,
_In_ DWORD MaximumEntryCount,
_In_ ULONG_PTR RangeBase,
_In_ ULONG_PTR RangeEnd
);


NTSYSAPI
void
NTAPI
RtlGrowFunctionTable(
_Inout_ PVOID DynamicTable,
_In_ DWORD NewEntryCount
);


NTSYSAPI
void
NTAPI
RtlDeleteGrowableFunctionTable(
_In_ PVOID DynamicTable
);

namespace v8 {
namespace internal {
namespace win64_unwindinfo {

0 comments on commit 0a6ed6f

Please sign in to comment.