lib,src,test: fix tests without SQLite

PR-URL: #60906
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: aduh95

node.gyp

@@ -927,7 +927,6 @@
           'sources': [
             '<@(node_sqlite_sources)',
           ],
-          'defines': [ 'HAVE_SQLITE=1' ],
         }],
         [ 'node_shared=="true" and node_module_version!="" and OS!="win"', {
           'product_extension': '<(shlib_suffix)',
@@ -981,7 +980,6 @@
           'sources': [
             '<@(node_sqlite_sources)',
           ],
-          'defines': [ 'HAVE_SQLITE=1' ],
         }],
         [ 'OS in "linux freebsd mac solaris openharmony" and '
           'target_arch=="x64" and '

node.gypi

@@ -440,5 +440,10 @@
     }, {
       'defines': [ 'HAVE_AMARO=0' ]
     }],
+    [ 'node_use_sqlite=="true"', {
+      'defines': [ 'HAVE_SQLITE=1' ],
+    }, {
+      'defines': [ 'HAVE_SQLITE=0' ]
+    }],
   ],
 }

test/common/index.js

@@ -350,8 +350,6 @@ const knownGlobals = new Set([
  'CompressionStream',
  'DecompressionStream',
  'Storage',
- 'localStorage',
- 'sessionStorage',
 ].forEach((i) => {
   if (globalThis[i] !== undefined) {
     knownGlobals.add(globalThis[i]);
@@ -365,6 +363,11 @@ if (hasCrypto) {
   knownGlobals.add(globalThis.SubtleCrypto);
 }
 
+if (hasSQLite) {
+  knownGlobals.add(globalThis.localStorage);
+  knownGlobals.add(globalThis.sessionStorage);
+}
+
 const { Worker } = require('node:worker_threads');
 knownGlobals.add(Worker);
 

test/module-hooks/test-module-hooks-builtin-require.js

@@ -12,11 +12,14 @@ const { registerHooks } = require('module');
 
 const schemelessBlockList = new Set([
   'sea',
-  'sqlite',
   'test',
   'test/reporters',
 ]);
 
+if (common.hasSQLite) {
+  schemelessBlockList.add('sqlite');
+}
+
 const testModules = [];
 for (const mod of schemelessBlockList) {
   testModules.push(`node:${mod}`);

test/module-hooks/test-module-hooks-load-builtin-require.js

@@ -36,11 +36,14 @@ hook.deregister();
 // stripped for internal lookups should not get passed into the hooks.
 const schemelessBlockList = new Set([
   'sea',
-  'sqlite',
   'test',
   'test/reporters',
 ]);
 
+if (common.hasSQLite) {
+  schemelessBlockList.add('sqlite');
+}
+
 const testModules = [];
 for (const mod of schemelessBlockList) {
   testModules.push(`node:${mod}`);

test/parallel/test-sqlite-config.js

@@ -2,8 +2,8 @@
 const { skipIfSQLiteMissing } = require('../common/index.mjs');
 const { test } = require('node:test');
 const assert = require('node:assert');
-const { DatabaseSync } = require('node:sqlite');
 skipIfSQLiteMissing();
+const { DatabaseSync } = require('node:sqlite');
 
 function checkDefensiveMode(db) {
   function journalMode() {

test/parallel/test-sqlite-template-tag.js

@@ -1,5 +1,7 @@
 'use strict';
-require('../common');
+const { skipIfSQLiteMissing } = require('../common');
+skipIfSQLiteMissing();
+
 const assert = require('assert');
 const { DatabaseSync } = require('node:sqlite');
 const { test, beforeEach } = require('node:test');

test/parallel/test-webstorage-without-sqlite.js

@@ -0,0 +1,10 @@
+'use strict';
+
+// Flags: --experimental-webstorage --localstorage-file=./test/fixtures/empty.js
+
+const { hasSQLite } = require('../common');
+const assert = require('node:assert');
+
+// Ensuring that `sessionStorage` is not a getter that throws when built without SQLite.
+assert.strictEqual(typeof sessionStorage, hasSQLite ? 'object' : 'undefined');
+assert.strictEqual(Object.hasOwn(globalThis, 'sessionStorage'), hasSQLite);

typings/internalBinding/config.d.ts

@@ -8,6 +8,7 @@ export interface ConfigBinding {
   hasTracing: boolean;
   hasNodeOptions: boolean;
   hasInspector: boolean;
+  hasSQLite: boolean;
   noBrowserGlobals: boolean;
   bits: number;
   getDefaultLocale(): string;