Update doc/api/deprecations.md

Co-authored-by: Livia Medeiros <livia@cirno.name>

Author: jasnell

doc/api/deprecations.md

@@ -2866,7 +2866,7 @@ To maintain existing behavior `response.finished` should be replaced with
 <!-- YAML
 changes:
   - version: REPLACEME
-    pr-url: https://github.com/nodejs/node/pull/00000
+    pr-url: https://github.com/nodejs/node/pull/58536
     description: End-of-Life.
   - version: v14.0.0
     pr-url: https://github.com/nodejs/node/pull/28396

src/base_object-inl.h

@@ -49,7 +49,7 @@ v8::Global<v8::Object>& BaseObject::persistent() {
 
 
 v8::Local<v8::Object> BaseObject::object() const {
-  return PersistentToLocal::Default(env()->isolate(), persistent_handle_);
+  return PersistentToLocal::Default(env()->isolate(), persistent_handle_); 
 }
 
 v8::Local<v8::Object> BaseObject::object(v8::Isolate* isolate) const {

src/node_file.cc

@@ -350,32 +350,34 @@ inline void FileHandle::Close() {
 
   AfterClose();
 
-  if (ret < 0) {
-    // Do not unref this
-    env()->SetImmediate([detail](Environment* env) {
+  // Even though we closed the file descriptor, we still throw an error
+  // if the FileHandle object was not closed before garbage collection.
+  // Because this method is called during garbage collection, we will defer
+  // throwing the error until the next immediate queue tick so as not
+  // to interfere with the gc process.
+  //
+  // This exception will end up being fatal for the process because
+  // it is being thrown from within the SetImmediate handler and
+  // there is no JS stack to bubble it to. In other words, tearing
+  // down the process is the only reasonable thing we can do here.
+  env()->SetImmediate([detail](Environment* env) {
+    HandleScope handle_scope(env->isolate());
+
+    // If there was an error while trying to close the file descriptor,
+    // we will throw that instead.
+    if (detail.ret < 0) {
       char msg[70];
       snprintf(msg, arraysize(msg),
               "Closing file descriptor %d on garbage collection failed",
               detail.fd);
-      // This exception will end up being fatal for the process because
-      // it is being thrown from within the SetImmediate handler and
-      // there is no JS stack to bubble it to. In other words, tearing
-      // down the process is the only reasonable thing we can do here.
       HandleScope handle_scope(env->isolate());
       env->ThrowUVException(detail.ret, "close", msg);
-    });
-    return;
-  }
+      return;
+    }
 
-  // Even though we closed the file descriptor, we still throw an error
-  // if the FileHandle object was not closed before garbage collection.
-  // Because this method is called during garbage collection, we will defer
-  // throwing the error until the next immediate queue tick so as not
-  // to interfere with the gc process.
-  env()->SetImmediate([](Environment* env) {
     THROW_ERR_INVALID_STATE(
         env,
-        "FileHandle object was not closed before garbage collection. "
+        "A FileHandle object was closed during garbage collection. "
         "This used to be allowed with a deprecation warning but is now "
         "considered an error. Please close FileHandle objects explicitly.");
   });

test/parallel/test-fs-filehandle.js

@@ -12,7 +12,7 @@ const { stringToFlags } = require('internal/fs/utils');
 // error is thrown if it is not closed.
 process.on('uncaughtException', common.mustCall((err) => {
   assert.strictEqual(err.code, 'ERR_INVALID_STATE');
-  assert.match(err.message, /^FileHandle object was not closed/);
+  assert.match(err.message, /^A FileHandle object was closed during/);
 }));