Skip to content

Commit 1396996

Browse files
danbevjasnell
authored andcommitted
src: use v8:: namepace consistently in node_file
Currently node_file.cc has a number of using declarations but in a few places still uses the qualified names. This commit changes this for consistency. PR-URL: #20059 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent cf46ca7 commit 1396996

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/node_file.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ FileHandle::FileHandle(Environment* env, int fd, Local<Object> obj)
108108
attr).FromJust();
109109
}
110110

111-
void FileHandle::New(const v8::FunctionCallbackInfo<v8::Value>& args) {
111+
void FileHandle::New(const FunctionCallbackInfo<Value>& args) {
112112
Environment* env = Environment::GetCurrent(args);
113113
CHECK(args.IsConstructCall());
114114
CHECK(args[0]->IsInt32());
115115

116116
FileHandle* handle =
117-
new FileHandle(env, args[0].As<v8::Int32>()->Value(), args.This());
117+
new FileHandle(env, args[0].As<Int32>()->Value(), args.This());
118118
if (args[1]->IsNumber())
119119
handle->read_offset_ = args[1]->IntegerValue(env->context()).FromJust();
120120
if (args[2]->IsNumber())
@@ -671,7 +671,7 @@ inline FSReqBase* GetReqWrap(Environment* env, Local<Value> value) {
671671
if (value->IsObject()) {
672672
return Unwrap<FSReqBase>(value.As<Object>());
673673
} else if (value->StrictEquals(env->fs_use_promises_symbol())) {
674-
return new FSReqPromise<double, v8::Float64Array>(env);
674+
return new FSReqPromise<double, Float64Array>(env);
675675
}
676676
return nullptr;
677677
}

0 commit comments

Comments
 (0)