Skip to content

Commit 139dbe8

Browse files
Shigeki Ohtsumhdawson
Shigeki Ohtsu
authored andcommitted
test: remove 512 bits test in test-tls-dhe.js
Test of 512 bits key is failed after upgrading openssl-1.0.1o due to its limit of 768 bits key size. Remove it and start from 1024 bits test. Reviewed-By: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node-v0.x-archive#25533
1 parent 097607c commit 139dbe8

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

Diff for: test/fixtures/keys/Makefile

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
all: agent1-cert.pem agent2-cert.pem agent3-cert.pem agent4-cert.pem agent5-cert.pem ca2-crl.pem ec-cert.pem dh512.pem dh1024.pem dh2048.pem
1+
all: agent1-cert.pem agent2-cert.pem agent3-cert.pem agent4-cert.pem agent5-cert.pem ca2-crl.pem ec-cert.pem dh1024.pem dh2048.pem
22

33

44
#
@@ -170,9 +170,6 @@ ec-cert.pem: ec-csr.pem ec-key.pem
170170
-signkey ec-key.pem \
171171
-out ec-cert.pem
172172

173-
dh512.pem:
174-
openssl dhparam -out dh512.pem 512
175-
176173
dh1024.pem:
177174
openssl dhparam -out dh1024.pem 1024
178175

Diff for: test/fixtures/keys/dh512.pem

-4
This file was deleted.

Diff for: test/simple/test-tls-dhe.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@ function test(keylen, expectedCipher, cb) {
8080
});
8181
}
8282

83-
function test512() {
84-
test(512, 'DHE-RSA-AES128-SHA256', test1024);
85-
ntests++;
86-
}
87-
8883
function test1024() {
8984
test(1024, 'DHE-RSA-AES128-SHA256', test2048);
9085
ntests++;
@@ -100,7 +95,7 @@ function testError() {
10095
ntests++;
10196
}
10297

103-
test512();
98+
test1024();
10499

105100
process.on('exit', function() {
106101
assert.equal(ntests, nsuccess);

0 commit comments

Comments
 (0)