Skip to content

Commit 1630a56

Browse files
committed
tools: avoid building twice in coverage jobs
PR-URL: #61899 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent dba9001 commit 1630a56

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/coverage-linux-without-intl.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ jobs:
7171
run: npx envinfo
7272
- name: Install gcovr
7373
run: pip install gcovr==7.2
74-
- name: Build
75-
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl"
74+
- name: Configure
75+
run: ./configure --verbose --error-on-warn --coverage --without-intl
7676
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
7777
# The cause is most likely coverage's use of the inspector.
78-
- name: Test
78+
- name: Build and test
7979
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
8080
- name: Report JS
8181
run: npx c8 report --check-coverage

.github/workflows/coverage-linux.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ jobs:
7171
run: npx envinfo
7272
- name: Install gcovr
7373
run: pip install gcovr==7.2
74-
- name: Build
75-
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
74+
- name: Configure
75+
run: ./configure --verbose --error-on-warn --coverage
7676
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
7777
# The cause is most likely coverage's use of the inspector.
78-
- name: Test
78+
- name: Build and test
7979
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
8080
- name: Report JS
8181
run: npx c8 report --check-coverage

0 commit comments

Comments
 (0)