Skip to content

Commit 1860e0c

Browse files
thefourtheyervagg
authored andcommittedSep 22, 2015
lib,src: remove usage of events.EventEmitter
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
1 parent 43e2b7f commit 1860e0c

15 files changed

+23
-22
lines changed
 

‎lib/_http_agent.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const net = require('net');
44
const util = require('util');
5-
const EventEmitter = require('events').EventEmitter;
5+
const EventEmitter = require('events');
66
const debug = util.debuglog('http');
77

88
// New Agent code.

‎lib/_http_client.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const util = require('util');
44
const net = require('net');
55
const url = require('url');
6-
const EventEmitter = require('events').EventEmitter;
6+
const EventEmitter = require('events');
77
const HTTPParser = process.binding('http_parser').HTTPParser;
88
const assert = require('assert').ok;
99
const common = require('_http_common');

‎lib/_http_server.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const util = require('util');
44
const net = require('net');
5-
const EventEmitter = require('events').EventEmitter;
5+
const EventEmitter = require('events');
66
const HTTPParser = process.binding('http_parser').HTTPParser;
77
const assert = require('assert').ok;
88
const common = require('_http_common');
@@ -117,7 +117,8 @@ function onServerResponseClose() {
117117
// array. That is, in the example below, b still gets called even though
118118
// it's been removed by a:
119119
//
120-
// var obj = new events.EventEmitter;
120+
// var EventEmitter = require('events');
121+
// var obj = new EventEmitter();
121122
// obj.on('event', a);
122123
// obj.on('event', b);
123124
// function a() { obj.removeListener('event', b) }

‎lib/_stream_readable.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
module.exports = Readable;
44
Readable.ReadableState = ReadableState;
55

6-
const EE = require('events').EventEmitter;
6+
const EE = require('events');
77
const Stream = require('stream');
88
const Buffer = require('buffer').Buffer;
99
const util = require('util');

‎lib/_tls_legacy.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
const assert = require('assert');
4-
const events = require('events');
4+
const EventEmitter = require('events');
55
const stream = require('stream');
66
const tls = require('tls');
77
const util = require('util');
@@ -672,7 +672,7 @@ function SecurePair(context, isServer, requestCert, rejectUnauthorized,
672672

673673
options || (options = {});
674674

675-
events.EventEmitter.call(this);
675+
EventEmitter.call(this);
676676

677677
this.server = options.server;
678678
this._secureEstablished = false;
@@ -741,7 +741,7 @@ function SecurePair(context, isServer, requestCert, rejectUnauthorized,
741741
process.nextTick(securePairNT, this, options);
742742
}
743743

744-
util.inherits(SecurePair, events.EventEmitter);
744+
util.inherits(SecurePair, EventEmitter);
745745

746746
function securePairNT(self, options) {
747747
/* The Connection may be destroyed by an abort call */

‎lib/cluster.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const EventEmitter = require('events').EventEmitter;
3+
const EventEmitter = require('events');
44
const assert = require('assert');
55
const dgram = require('dgram');
66
const fork = require('child_process').fork;

‎lib/dgram.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const assert = require('assert');
44
const Buffer = require('buffer').Buffer;
55
const util = require('util');
6-
const events = require('events');
6+
const EventEmitter = require('events');
77
const constants = require('constants');
88

99
const UDP = process.binding('udp_wrap').UDP;
@@ -79,7 +79,7 @@ exports._createSocketHandle = function(address, port, addressType, fd, flags) {
7979

8080

8181
function Socket(type, listener) {
82-
events.EventEmitter.call(this);
82+
EventEmitter.call(this);
8383

8484
if (typeof type === 'object') {
8585
var options = type;
@@ -101,7 +101,7 @@ function Socket(type, listener) {
101101
if (typeof listener === 'function')
102102
this.on('message', listener);
103103
}
104-
util.inherits(Socket, events.EventEmitter);
104+
util.inherits(Socket, EventEmitter);
105105
exports.Socket = Socket;
106106

107107

‎lib/fs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const constants = require('constants');
1212
const fs = exports;
1313
const Buffer = require('buffer').Buffer;
1414
const Stream = require('stream').Stream;
15-
const EventEmitter = require('events').EventEmitter;
15+
const EventEmitter = require('events');
1616
const FSReqWrap = binding.FSReqWrap;
1717
const FSEvent = process.binding('fs_event_wrap').FSEvent;
1818

‎lib/http.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const util = require('util');
44
const internalUtil = require('internal/util');
5-
const EventEmitter = require('events').EventEmitter;
5+
const EventEmitter = require('events');
66

77

88
exports.IncomingMessage = require('_http_incoming').IncomingMessage;

‎lib/internal/child_process.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const StringDecoder = require('string_decoder').StringDecoder;
44
const Buffer = require('buffer').Buffer;
5-
const EventEmitter = require('events').EventEmitter;
5+
const EventEmitter = require('events');
66
const net = require('net');
77
const dgram = require('dgram');
88
const util = require('util');

‎lib/internal/socket_list.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module.exports = {SocketListSend, SocketListReceive};
44

5-
const EventEmitter = require('events').EventEmitter;
5+
const EventEmitter = require('events');
66
const util = require('util');
77

88
// This object keep track of the socket there are sended

‎lib/net.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const events = require('events');
3+
const EventEmitter = require('events');
44
const stream = require('stream');
55
const timers = require('timers');
66
const util = require('util');
@@ -1071,7 +1071,7 @@ function Server(options, connectionListener) {
10711071
if (!(this instanceof Server))
10721072
return new Server(options, connectionListener);
10731073

1074-
events.EventEmitter.call(this);
1074+
EventEmitter.call(this);
10751075

10761076
var self = this;
10771077
var options;
@@ -1113,7 +1113,7 @@ function Server(options, connectionListener) {
11131113
this.allowHalfOpen = options.allowHalfOpen || false;
11141114
this.pauseOnConnect = !!options.pauseOnConnect;
11151115
}
1116-
util.inherits(Server, events.EventEmitter);
1116+
util.inherits(Server, EventEmitter);
11171117
exports.Server = Server;
11181118

11191119

‎lib/readline.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const util = require('util');
1212
const internalUtil = require('internal/util');
1313
const inherits = util.inherits;
1414
const Buffer = require('buffer').Buffer;
15-
const EventEmitter = require('events').EventEmitter;
15+
const EventEmitter = require('events');
1616

1717

1818
exports.createInterface = function(input, output, completer, terminal) {

‎lib/stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module.exports = Stream;
44

5-
const EE = require('events').EventEmitter;
5+
const EE = require('events');
66
const util = require('util');
77

88
util.inherits(Stream, EE);

‎src/node.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
this.global = this;
1111

1212
function startup() {
13-
var EventEmitter = NativeModule.require('events').EventEmitter;
13+
var EventEmitter = NativeModule.require('events');
1414

1515
process.__proto__ = Object.create(EventEmitter.prototype, {
1616
constructor: {

0 commit comments

Comments
 (0)
Please sign in to comment.