Skip to content

Commit 1974fd9

Browse files
BridgeARBethGriggs
authored andcommitted
tools: allow the travis commit message job to fail
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 1607d38 commit 1974fd9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,4 @@ jobs:
8888
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
8989
allow_failures: # TODO (cclauss): remove this when dependencies are clean
9090
- name: "Find syntax errors in our Python dependencies"
91+
- name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"

0 commit comments

Comments
 (0)