Skip to content

Commit

Permalink
tools: do not disable ICU's transliteration
Browse files Browse the repository at this point in the history
V8 needs it for case conversion.
Ref: https://codereview.chromium.org/1812673005

PR-URL: #8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
  • Loading branch information
targos authored and jasnell committed Sep 29, 2016
1 parent 8481ea1 commit 1a93e03
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion tools/icu/icu-generic.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
}],
],
'defines': [
'UCONFIG_NO_TRANSLITERATION=1',
'UCONFIG_NO_SERVICE=1',
'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
'U_ENABLE_DYLOAD=0',
Expand Down
2 changes: 1 addition & 1 deletion tools/icu/icu_small.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"zone": "locales",
"converters": "none",
"stringprep": "locales",
"translit": "none",
"translit": "locales",
"brkfiles": "none",
"brkdict": "none",
"confusables": "none",
Expand Down

0 comments on commit 1a93e03

Please sign in to comment.