fixup! test: ensure assertions are reached on more tests

aduh95 · aduh95 · commit 1cd3ddf30d64 · 2025-11-18T22:42:00.000+01:00
fix Windows tests
diff --git a/test/parallel/test-repl-persistent-history.js b/test/parallel/test-repl-persistent-history.js
@@ -140,7 +140,7 @@ const tests = [
     before: common.mustCall(function before() {
       if (common.isWindows) {
         const execSync = require('child_process').execSync;
-        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, common.mustSucceed());
+        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`);
       }
     }),
     env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },
diff --git a/test/parallel/test-repl-programmatic-history-setup-history.js b/test/parallel/test-repl-programmatic-history-setup-history.js
@@ -141,7 +141,7 @@ const tests = [
     before: common.mustCall(function before() {
       if (common.isWindows) {
         const execSync = require('child_process').execSync;
-        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, common.mustSucceed());
+        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`);
       }
     }),
     env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },
diff --git a/test/parallel/test-repl-programmatic-history.js b/test/parallel/test-repl-programmatic-history.js
@@ -134,7 +134,7 @@ const tests = [
     before: common.mustCall(function before() {
       if (common.isWindows) {
         const execSync = require('child_process').execSync;
-        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, common.mustSucceed());
+        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`);
       }
     }),
     env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ const tests = [`
`140`	`140`	`before: common.mustCall(function before() {`
`141`	`141`	`if (common.isWindows) {`
`142`	`142`	`const execSync = require('child_process').execSync;`
`143`		- execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, common.mustSucceed());
	`143`	+ execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`);
`144`	`144`	`}`
`145`	`145`	`}),`
`146`	`146`	`env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ const tests = [`
`141`	`141`	`before: common.mustCall(function before() {`
`142`	`142`	`if (common.isWindows) {`
`143`	`143`	`const execSync = require('child_process').execSync;`
`144`		- execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, common.mustSucceed());
	`144`	+ execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`);
`145`	`145`	`}`
`146`	`146`	`}),`
`147`	`147`	`env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },`
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ const tests = [`
`134`	`134`	`before: common.mustCall(function before() {`
`135`	`135`	`if (common.isWindows) {`
`136`	`136`	`const execSync = require('child_process').execSync;`
`137`		- execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, common.mustSucceed());
	`137`	+ execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`);
`138`	`138`	`}`
`139`	`139`	`}),`
`140`	`140`	`env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },`