Skip to content

Commit

Permalink
test: refactor /parallel/test-cluster-uncaught-exception.js to ES6
Browse files Browse the repository at this point in the history
Replaces function expressions with ES6 arrow functions as well as
improve the comparison operator to check if operands are of same types.

PR-URL: #9239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
deverickapollo authored and Myles Borins committed Nov 22, 2016
1 parent 2388648 commit 1d54f07
Showing 1 changed file with 10 additions and 13 deletions.
23 changes: 10 additions & 13 deletions test/parallel/test-cluster-uncaught-exception.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,23 @@
// https://github.com/joyent/node/issues/2556

const common = require('../common');
var assert = require('assert');
var cluster = require('cluster');
var fork = require('child_process').fork;
const assert = require('assert');
const cluster = require('cluster');
const fork = require('child_process').fork;

var MAGIC_EXIT_CODE = 42;
const MAGIC_EXIT_CODE = 42;

var isTestRunner = process.argv[2] != 'child';
const isTestRunner = process.argv[2] !== 'child';

if (isTestRunner) {
var master = fork(__filename, ['child']);
master.on('exit', common.mustCall(function(code) {
const master = fork(__filename, ['child']);
master.on('exit', common.mustCall((code) => {
assert.strictEqual(code, MAGIC_EXIT_CODE);
}));
} else if (cluster.isMaster) {
process.on('uncaughtException', function() {
process.nextTick(function() {
process.exit(MAGIC_EXIT_CODE);
});
});

process.on('uncaughtException', common.mustCall(() => {
process.nextTick(() => process.exit(MAGIC_EXIT_CODE));
}));
cluster.fork();
throw new Error('kill master');
} else { // worker
Expand Down

0 comments on commit 1d54f07

Please sign in to comment.