Skip to content

Commit

Permalink
src: fix resource leak in node::fs::FileHandle
Browse files Browse the repository at this point in the history
PR-URL: #23793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
refack authored and rvagg committed Nov 28, 2018
1 parent c0a9a83 commit 260d777
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class FileHandle : public AsyncWrap, public StreamBase {
ref_.Reset(env->isolate(), ref);
}

~CloseReq() {
~CloseReq() override {
uv_fs_req_cleanup(req());
promise_.Reset();
ref_.Reset();
Expand Down

0 comments on commit 260d777

Please sign in to comment.