Skip to content

Commit

Permalink
src: allow --tls-cipher-list in NODE_OPTIONS
Browse files Browse the repository at this point in the history
PR-URL: #13172
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information
sam-github authored and jasnell committed May 28, 2017
1 parent 2648c8d commit 287b11d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ Node options that are allowed are:
- `--redirect-warnings`
- `--require`, `-r`
- `--throw-deprecation`
- `--tls-cipher-list`
- `--trace-deprecation`
- `--trace-events-categories`
- `--trace-events-enabled`
Expand Down
3 changes: 2 additions & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3712,7 +3712,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
size_t arglen = eq ? eq - arg : strlen(arg);

static const char* whitelist[] = {
// Node options
// Node options, sorted in `node --help` order for ease of comparison.
"--require", "-r",
"--inspect",
"--inspect-brk",
Expand All @@ -3730,6 +3730,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
"--track-heap-objects",
"--zero-fill-buffers",
"--v8-pool-size",
"--tls-cipher-list",
"--use-bundled-ca",
"--use-openssl-ca",
"--enable-fips",
Expand Down

0 comments on commit 287b11d

Please sign in to comment.