Skip to content

Commit 291cedf

Browse files
joyeecheungaddaleax
authored andcommitted
src: reduce includes of node_internals.h
PR-URL: #25507 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent efe089e commit 291cedf

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+153
-158
lines changed

src/async_wrap.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "async_wrap-inl.h"
2323
#include "env-inl.h"
2424
#include "node_errors.h"
25-
#include "node_internals.h"
2625
#include "tracing/traced_value.h"
2726
#include "util-inl.h"
2827

src/cares_wrap.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "async_wrap-inl.h"
2525
#include "env-inl.h"
2626
#include "node.h"
27-
#include "node_internals.h"
2827
#include "req_wrap-inl.h"
2928
#include "util-inl.h"
3029
#include "uv.h"

src/connection_wrap.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
#include "connect_wrap.h"
44
#include "env-inl.h"
55
#include "pipe_wrap.h"
6-
#include "node_internals.h"
76
#include "stream_base-inl.h"
87
#include "stream_wrap.h"
98
#include "tcp_wrap.h"

src/debug_utils.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#include "debug_utils.h"
2-
#include "node_internals.h"
32

43
#ifdef __POSIX__
54
#if defined(__linux__)

src/debug_utils.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
55

66
#include "async_wrap.h"
7-
#include "env.h"
8-
#include <string>
7+
#include "env-inl.h"
8+
99
#include <sstream>
10+
#include <string>
1011

1112
// Use FORCE_INLINE on functions that have a debug-category-enabled check first
1213
// and then ideally only a single function call following it, to maintain

src/fs_event_wrap.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "env-inl.h"
2424
#include "util-inl.h"
2525
#include "node.h"
26-
#include "node_internals.h"
2726
#include "handle_wrap.h"
2827
#include "string_bytes.h"
2928

src/heap_utils.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
#include "node_internals.h"
2-
#include "env.h"
1+
#include "env-inl.h"
32

43
using v8::Array;
54
using v8::Boolean;

src/inspector_js_api.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#include "base_object-inl.h"
22
#include "inspector_agent.h"
33
#include "inspector_io.h"
4-
#include "node_internals.h"
54
#include "v8.h"
65
#include "v8-inspector.h"
76

src/js_stream.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
#include "env-inl.h"
55
#include "node_buffer.h"
66
#include "node_errors.h"
7-
#include "node_internals.h"
87
#include "stream_base-inl.h"
98
#include "v8.h"
109

src/module_wrap.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include "node_errors.h"
88
#include "node_url.h"
99
#include "util-inl.h"
10-
#include "node_internals.h"
1110
#include "node_contextify.h"
1211
#include "node_watchdog.h"
1312

0 commit comments

Comments
 (0)