-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: fix flaky test-net-socket-timeout-unref
Throw immediately on socket timeout rather than checking boolean in exit handler. PR-URL: #6003 Fixes: #5128 Reviewed-By: Myles Borins <myles.borins@gmail.com>
- Loading branch information
Showing
1 changed file
with
16 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,35 @@ | ||
'use strict'; | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var net = require('net'); | ||
|
||
var server = net.createServer(function(c) { | ||
// Test that unref'ed sockets with timeouts do not prevent exit. | ||
|
||
const common = require('../common'); | ||
const net = require('net'); | ||
|
||
const server = net.createServer(function(c) { | ||
c.write('hello'); | ||
c.unref(); | ||
}); | ||
server.listen(common.PORT); | ||
server.unref(); | ||
|
||
var timedout = false; | ||
var connections = 0; | ||
var sockets = []; | ||
var delays = [8, 5, 3, 6, 2, 4]; | ||
const sockets = []; | ||
const delays = [8, 5, 3, 6, 2, 4]; | ||
|
||
delays.forEach(function(T) { | ||
var socket = net.createConnection(common.PORT, 'localhost'); | ||
socket.on('connect', function() { | ||
const socket = net.createConnection(common.PORT, 'localhost'); | ||
socket.on('connect', common.mustCall(function() { | ||
if (++connections === delays.length) { | ||
sockets.forEach(function(s) { | ||
s[0].setTimeout(s[1] * 1000, function() { | ||
timedout = true; | ||
s[0].destroy(); | ||
s.socket.setTimeout(s.timeout, function() { | ||
s.socket.destroy(); | ||
throw new Error('socket timed out unexpectedly'); | ||
}); | ||
|
||
s[0].unref(); | ||
s.socket.unref(); | ||
}); | ||
} | ||
}); | ||
|
||
sockets.push([socket, T]); | ||
}); | ||
})); | ||
|
||
process.on('exit', function() { | ||
assert.strictEqual(timedout, false, | ||
'Socket timeout should not hold loop open'); | ||
sockets.push({socket: socket, timeout: T * 1000}); | ||
}); |