Skip to content

Commit

Permalink
build: compile with C++20 support on Windows
Browse files Browse the repository at this point in the history
Our Linux build infra is not ready for it yet,
but V8 is making it difficult to compile on Windows
without it.

Refs: #45402
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
StefanStojanovic authored and RafaelGSS committed Apr 22, 2024
1 parent 5bde9e6 commit 2b1e7c2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@
'VCCLCompilerTool': {
'AdditionalOptions': [
'/Zc:__cplusplus',
'-std:c++17'
# The following option enables c++20 on Windows. This is needed for V8 v12.4+
'-std:c++20',
],
'BufferSecurityCheck': 'true',
'DebugInformationFormat': 1, # /Z7 embed info in .obj files
Expand Down

0 comments on commit 2b1e7c2

Please sign in to comment.