-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This test assures that if flush is called while the zlib object needs to be drained that it will defer the callback until after the drain. PR-URL: #3534 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
1 parent
33ffc62
commit 2ec5e17
Showing
1 changed file
with
49 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const zlib = require('zlib'); | ||
const path = require('path'); | ||
|
||
const bigData = new Buffer(10240).fill('x'); | ||
|
||
const opts = { | ||
level: 0, | ||
highWaterMark: 16 | ||
}; | ||
|
||
const deflater = zlib.createDeflate(opts); | ||
|
||
// shim deflater.flush so we can count times executed | ||
var flushCount = 0; | ||
var drainCount = 0; | ||
|
||
const flush = deflater.flush; | ||
deflater.flush = function(kind, callback) { | ||
flushCount++; | ||
flush.call(this, kind, callback); | ||
}; | ||
|
||
deflater.write(bigData); | ||
|
||
const ws = deflater._writableState; | ||
const beforeFlush = ws.needDrain; | ||
var afterFlush = ws.needDrain; | ||
|
||
deflater.flush(function(err) { | ||
afterFlush = ws.needDrain; | ||
}); | ||
|
||
deflater.on('drain', function() { | ||
drainCount++;; | ||
}); | ||
|
||
process.once('exit', function() { | ||
assert.equal(beforeFlush, true, | ||
'before calling flush the writable stream should need to drain'); | ||
assert.equal(afterFlush, false, | ||
'after calling flush the writable stream should not need to drain'); | ||
assert.equal(drainCount, 1, | ||
'the deflater should have emitted a single drain event'); | ||
assert.equal(flushCount, 2, | ||
'flush should be called twice'); | ||
}); |