Skip to content

Commit

Permalink
build,deps: add NOMINMAX to V8 Windows builds
Browse files Browse the repository at this point in the history
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620

PR-URL: #25852
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
  • Loading branch information
refack authored and targos committed Mar 14, 2019
1 parent 1c494b0 commit 3531fe9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions deps/v8/gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,7 @@
['OS=="win"', {
'defines': [
'WIN32',
'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
],
# 4351: VS 2005 and later are warning us that they've fixed a bug
# present in VS 2003 and earlier.
Expand Down

0 comments on commit 3531fe9

Please sign in to comment.