Skip to content

Commit 3752a7e

Browse files
committed
build: build v8 with -fvisibility=hidden
This enables -fvisibility=hidden on platforms other than macOS, wherever it's supported.
1 parent 3b1bdd4 commit 3752a7e

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tools/v8_gypfiles/v8.gyp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@
4242
}
4343
},
4444
# Hide symbols that are not explicitly exported with V8_EXPORT.
45-
# TODO(joyeecheung): enable it on other platforms. Currently gcc times out
46-
# or run out of memory with -fvisibility=hidden on some machines in the CI.
45+
'cflags': ['-fvisibility=hidden'],
4746
'xcode_settings': {
4847
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
4948
},

0 commit comments

Comments
 (0)